Re: [U-Boot] [PATCH v2 10/11] arm: dts: socfpga: Add dts for Stratix 10 socdk

[Chin Liang See]

On Tue, 2016-09-06 at 09:14 -0500, Dinh Nguyen wrote:
> 
> On 09/06/2016 05:03 AM, Chin Liang See wrote:
> > Add device tree for Stratix 10 SoC development kit
> > 
> > Signed-off-by: Chin Liang See <cl...@altera.com>
> > Cc: Marek Vasut <ma...@denx.de>
> > Cc: Dinh Nguyen <dingu...@opensource.altera.com>
> > Cc: Ley Foon Tan <lf...@altera.com>
> > Acked-by: Marek Vasut <ma...@denx.de>
> > ---
> >  arch/arm/dts/Makefile                    |  3 +-
> >  arch/arm/dts/socfpga_stratix10_socdk.dts | 63
> > ++++++++++++++++++++++++++++++++
> >  2 files changed, 65 insertions(+), 1 deletion(-)
> >  create mode 100755 arch/arm/dts/socfpga_stratix10_socdk.dts
> > 
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index 223124e..c5e2d3c 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -127,7 +127,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA) +=                   
> >     \
> >     socfpga_cyclone5_sockit.dtb                     \
> >     socfpga_cyclone5_socrates.dtb                   \
> >     socfpga_cyclone5_sr1500.dtb                     \
> > -   socfpga_cyclone5_vining_fpga.dtb
> > +   socfpga_cyclone5_vining_fpga.dtb                \
> > +   socfpga_stratix10_socdk.dtb
> >  
> >  dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb
> >  dtb-$(CONFIG_TARGET_AM57XX_EVM) += am57xx-beagle-x15.dtb \
> > diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts
> > b/arch/arm/dts/socfpga_stratix10_socdk.dts
> > new file mode 100755
> > index 0000000..7465358
> > --- /dev/null
> > +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts
> > @@ -0,0 +1,63 @@
> > +/*
> > + *  Copyright (C) 2016 Intel Corporation
> > + *
> > + * SPDX-License-Identifier:        GPL-2.0
> > + */
> > +
> > +/dts-v1/;
> > +/* First 4KB has trampoline code for secondary cores. */
> > +/memreserve/ 0x00000000 0x0001000;
> 
> ARM64 should be using PSCI for SMP. I don't think the trampoline code
> is
> needed.
> 

You are right and will remove this

> > +#include "skeleton.dtsi"
> > +
> > +/ {
> > +   model = "Altera SOCFPGA Stratix 10 SoC Development Kit";
> > +   compatible = "altr,socfpga-stratix10", "altr,socfpga";
> > +
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +
> > +   chosen {
> > +           bootargs = "console=ttyS0,115200";
> > +   };
> > +
> > +   memory {
> > +           name = "memory";
> > +           device_type = "memory";
> > +           reg = <0x0 0x40000000>; /* 1GB */
> > +   };
> 
> are you sure we still have only 1GB?
> 

Good catch as SOCVP has 2GB. But we should have more than 2GB per spec
and will investigate more.

> > +
> > +   regulator_3_3v: 3-3-v-regulator {
> > +           compatible = "regulator-fixed";
> > +           regulator-name = "3.3V";
> > +           regulator-min-microvolt = <3300000>;
> > +           regulator-max-microvolt = <3300000>;
> > +   };
> > +
> > +   soc {
> > +           #address-cells = <1>;
> > +           #size-cells = <1>;
> > +           compatible = "simple-bus";
> > +           device_type = "soc";
> > +           ranges;
> > +
> > +           mmc0: dwmmc0@0xff808000 {
> > +                   compatible = "altr,socfpga-dw-mshc";
> > +                   reg = <0xff808000 0x1000>;
> > +                   interrupts = <0 139 4>;
> 
> This interrupt number is not correct. Copy/paste error from Cyclone5?
> For S10, I think it's 96.
> 

Yup, my bad as overlook this when enabling the SDMMC. Will fix this.

Thanks
Chin Liang

> > +                   num-slots = <1>;
> > +                   broken-cd;
> > +                   bus-width = <4>;
> > +                   fifo-depth = <0x400>;
> > +                   #address-cells = <1>;
> > +                   #size-cells = <0>;
> > +                   cap-mmc-highspeed;
> > +                   cap-sd-highspeed;
> > +                   drvsel = <3>;
> > +                   smplsel = <0>;
> > +                   status = "okay";
> > +                   u-boot,dm-pre-reloc;
> > +                   vmmc-supply = <&regulator_3_3v>;
> > +                   vqmmc-supply = <&regulator_3_3v>;
> > +           };
> > +   };
> > +};
> > 
> 
> Dinh
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot