On Friday 26 August 2016 10:38 AM, Lokesh Vutla wrote: > > > On Friday 26 August 2016 10:36 AM, Lokesh Vutla wrote: >> [..snip..] >> >>> diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h >>> index 46e8d4cfd715..3d5ae1ae1d54 100644 >>> --- a/include/configs/am57xx_evm.h >>> +++ b/include/configs/am57xx_evm.h >>> @@ -41,6 +41,47 @@ >>> "uuid_disk=${uuid_gpt_disk};" \ >>> "name=rootfs,start=2MiB,size=-,uuid=${uuid_gpt_rootfs}" >>> >>> +#define DFU_ALT_INFO_MMC \ >>> + "dfu_alt_info_mmc=" \ >>> + "boot part 0 1;" \ >>> + "rootfs part 0 2;" \ >>> + "MLO fat 0 1;" \ >>> + "MLO.raw raw 0x100 0x100;" \ >>> + "u-boot.img.raw raw 0x300 0x400;" \ >>> + "spl-os-args.raw raw 0x80 0x80;" \ >>> + "spl-os-image.raw raw 0x900 0x2000;" \ >>> + "spl-os-args fat 0 1;" \ >>> + "spl-os-image fat 0 1;" \ >>> + "u-boot.img fat 0 1;" \ >>> + "uEnv.txt fat 0 1\0" >>> + >>> +#define DFU_ALT_INFO_EMMC \ >>> + "dfu_alt_info_emmc=" \ >>> + "rawemmc raw 0 3751936;" \ >>> + "boot part 1 1;" \ >>> + "rootfs part 1 2;" \ >>> + "MLO fat 1 1;" \ >>> + "MLO.raw raw 0x100 0x100;" \ >>> + "u-boot.img.raw raw 0x300 0x400;" \ >>> + "spl-os-args.raw raw 0x80 0x80;" \ >>> + "spl-os-image.raw raw 0x900 0x2000;" \ >>> + "spl-os-args fat 1 1;" \ >>> + "spl-os-image fat 1 1;" \ >>> + "u-boot.img fat 1 1;" \ >>> + "uEnv.txt fat 1 1\0" >>> + >>> +#define DFU_ALT_INFO_RAM \ >>> + "dfu_alt_info_ram=" \ >>> + "kernel ram 0x80200000 0x4000000;" \ >>> + "fdt ram 0x80f80000 0x80000;" \ >>> + "ramdisk ram 0x81000000 0x4000000\0" >>> + >>> +#define DFUARGS \ >>> + "dfu_bufsiz=0x10000\0" \ >>> + DFU_ALT_INFO_MMC \ >>> + DFU_ALT_INFO_EMMC \ >>> + DFU_ALT_INFO_RAM \ >>> + >> >> Can you also add DFU_ALT_INFO_QSPI as am57xx-idk has QSPI. > > Any reason why these cannot be moved to ti_omap5_common.h?
No reason, I guess, just that its being done per platform today. If we are going to make it common, why not a step further and move it to ti_armv7_common.h so that similar looking defines from am335x_evm.h and am43xx_evm.h can be eliminated as well? Or do you see any reason why am335x and am437x need to be kept different. Thanks, Sekhar _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot