Hi Masahiro,
On 24 August 2016 at 19:28, Masahiro Yamada
<yamada.masah...@socionext.com> wrote:
> 2016-08-25 1:51 GMT+09:00 Simon Glass <s...@chromium.org>:
>> There are a lot of SPL options in U-Boot to enable various features and
>> drivers. Currently these do not use Kconfig. Add them to Kconfig along
>> with suitable help, and drop them from the README.
>>
>> Signed-off-by: Simon Glass <s...@chromium.org>
>> ---
>>
>> README | 49 -------
>> common/spl/Kconfig | 410
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 410 insertions(+), 49 deletions(-)
>>
>> diff --git a/README b/README
>> index 30d7ee3..ebc83d2 100644
>
>
>
>
>> +
>> +config SPL_MPC8XXX_INIT_DDR_SUPPORT
>> + bool "Support MPC8XXX DDR init"
>> + depends on SPL
>> + help
>> + Enable support for DDR-SDRAM (double-data-rate synchronous dynamic
>> + random-access memory) on the MPC8XXX family within SPL. This
>> + allows DRAM to be set up before loading U-Boot into that DRAM,
>> + where it can run.
>> +
>
> This sounds really SoC specific.
>
> Does it make sense to put it in common/spl/Kconfig?
>
Not really, but it is easy enough to move as a follow-on patch. The
hard part is moving it to Kconfig.
>
>
>
>
> We may want to rename
>
> CONFIG_SPL_I2C_SUPPORT -> CONFIG_SPL_I2C
> CONFIG_SPL_GPIO_SUPPORT -> CONFIG_SPL_GPIO
>
> in the future?
That makes sense to me. Again it is an easy subsequent step. I really
don't want to have to do that in the same commit.
>
>
> Do you prefer to collect all SPL configs in common/spl/Kconfig
> instead of drivers/{i2c,gpio}/Kconfig?
Actually I think having them in drivers/ makes more sense, but that
can be a subsequent patch. It's very each to do that sort of patch
once we have things in Kconfig.
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
