2016-08-25 1:52 GMT+09:00 Simon Glass <s...@chromium.org>: > Move this option to Kconfig and tidy up existing uses. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > configs/chromebook_jerry_defconfig | 1 + > configs/evb-rk3288_defconfig | 1 + > configs/fennec-rk3288_defconfig | 1 + > configs/firefly-rk3288_defconfig | 1 + > configs/miniarm-rk3288_defconfig | 1 + > configs/popmetal-rk3288_defconfig | 1 + > configs/rock2_defconfig | 1 + > include/configs/rk3288_common.h | 2 -- > 8 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/configs/chromebook_jerry_defconfig > b/configs/chromebook_jerry_defconfig > index d7f9f47..7ca2009 100644 > --- a/configs/chromebook_jerry_defconfig > +++ b/configs/chromebook_jerry_defconfig > @@ -13,6 +13,7 @@ CONFIG_SPL_DRIVERS_MISC_SUPPORT=y > CONFIG_SPL_I2C_SUPPORT=y > CONFIG_SPL_LIBCOMMON_SUPPORT=y > CONFIG_SPL_LIBGENERIC_SUPPORT=y > +CONFIG_SPL_PINCTRL_SUPPORT=y > CONFIG_HUSH_PARSER=y > CONFIG_CMD_BOOTZ=y > # CONFIG_CMD_IMLS is not set
Wait! I see only one define in rk3288_common.h, but I did not see any reference of it. $ git grep CONFIG_SPL_PINCTRL_SUPPORT include/configs/rk3288_common.h:#define CONFIG_SPL_PINCTRL_SUPPORT I was surprised at this because we already have the following in drivers/pinctrl/Kconfig: config SPL_PINCTRL bool "Support pin controlloers in SPL" depends on SPL && SPL_DM help This option is an SPL-variant of the PINCTRL option. See the help of PINCTRL for details. The right thing is to just remove the unreferenced CONFIG_SPL_PINCTRL_SUPPORT. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot