On Mon, Sep 21, 2009 at 10:36 AM, Paul Gortmaker <paul.gortma...@windriver.com> wrote: > Sweep throught the board specific file and replace the various > register proddings with the equivalent I/O accessors. > > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> > ---
> > - ecm->eedr = 0xffffffff; /* clear ecm errors */ > - ecm->eeer = 0xffffffff; /* enable ecm errors */ > + out_be32(&ecm->eedr, 0xffffffff); /* clear ecm errors */ > + out_be32(&ecm->eeer, 0xffffffff); /* enable ecm errors */ > return 0; Correct me if I'm wrong, but I thought the general rule was the other way (i.e. the way it alreay was). See for example: http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=ed7a1b681de1e31d18d5b92e2767ae8df3241687 This prevents, for example, accidentally writing words and longs to byte sized registers. Regards, G _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot