Dear Peter Tyser, In message <1253313414-6907-1-git-send-email-pty...@xes-inc.com> you wrote: > This change adds some basic summary information to the MAKEALL script. > The summary information includes how many boards were compiled, how many > boards had compile warnings or errors, and which specific boards had > compile warnings or errors. > > This information is useful when doing compile testing to quickly > determine which boards are broken. > > As a side benefit, no empty $BOARD.ERR files are generated by MAKEALL. > Previously, each board had a corresponding $BOARD.ERR file, even if the > board compiled cleanly.
OK, one concern, though: > + ERR=$(${MAKE} ${JOBS} all 2>&1 > ${LOG_DIR}/$target.MAKELOG) Please do not attempt to buffer the output in a shell variable. Besindes bash's nasty ways of dealing with single and double quotes, this may eventually overrun memory limitations. Please use a (temp) file instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Save yourself! Reboot in 5 seconds! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot