>From: york sun > >Sriram, > >Please pay attention to the language. "errata" is the plural noun of >"erratum". You >are dealing with one erratum, aren't you? And you are modifying the workaround, >not the erratum itself. > >The tags in the subject should be separated by either "/", or ":", but not >both. I don't >believe "cpu_init" should be in the tag. >
Hello York, Will take care from next time onwards. Will change in v3. > >On 07/17/2016 08:47 PM, Sriram Dash wrote: >> Modifies errata implementation due to the fact that P3041, >> P5020, and P5040 are all big endian for the USB PHY registers, but >> they were specified little endian. > >If your change is correct, can you explain why the original format >didn't cause any harm before? > >York > If it is working due to SWAP most likely reason would be bit[9] of confige1 which might be getting mapped to HS Disconnect decrement by 50mV. Whereas Errata intends to increase the threshold by 100mV though bit C1[8:9] which map to C1[23:22] in BG. I mean in full swap, this value will have maximum impact, although complete write is expected to be done properly. >> >> Signed-off-by: Sriram Dash <sriram.d...@nxp.com> >> Signed-off-by: Rajesh Bhagat <rajesh.bha...@nxp.com> >> --- >> Changes in v2: >> - Adds the errata number to title of patch >> - Makes separate patch for addition of errata to specific Socs. >> >> >> arch/powerpc/cpu/mpc85xx/cpu_init.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c >b/arch/powerpc/cpu/mpc85xx/cpu_init.c >> index 61f5639..61dedfc 100644 >> --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c >> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c >> @@ -114,10 +114,10 @@ void fsl_erratum_a006261_workaround(struct >ccsr_usb_phy __iomem *usb_phy) >> setbits_be32(&usb_phy->config2, >> CONFIG_SYS_FSL_USB_RX_AUTO_CAL_RD_WR_SEL); >> >> - temp = squelch_prog_rd_0_2 << >CONFIG_SYS_FSL_USB_SQUELCH_PROG_WR_0; >> + temp = squelch_prog_rd_0_2 << >CONFIG_SYS_FSL_USB_SQUELCH_PROG_WR_3; >> out_be32(&usb_phy->config2, in_be32(&usb_phy->config2) | temp); >> >> - temp = squelch_prog_rd_3_5 << >CONFIG_SYS_FSL_USB_SQUELCH_PROG_WR_3; >> + temp = squelch_prog_rd_3_5 << >CONFIG_SYS_FSL_USB_SQUELCH_PROG_WR_0; >> out_be32(&usb_phy->config2, in_be32(&usb_phy->config2) | temp); >> #endif >> } >> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
