On Tue, Jul 26, 2016 at 12:59:14PM +0000, B, Ravi wrote: > Tom > > >> based on phys_addr_t, so it triggered > >> the problem for DWC3, which had already potentially existed. > >> > >> > >> CONFIGs in Kconfig are guaranteed to be defined for all files, but > >> CONFIGs in board headers are not. > >> > >> So we need to make sure to add > >> #include <common.h> (or #include <config.h>) in each source file. > >> > >> > >> So, your patch is doing a right thing. > >> > >> I will issue my Reviewed-by when you update the git-log. > >> > >> > >> (Moving CONFIG_PHYS_64BIT is a right thing as well) > > >Can we move PHYS_64BIT to Kconfig instead here please? This is the kind of > >thing we should be able to select based on SoC / board. Thanks! > > Yes, moving to PHYS_64BIT to Kconfig would be ideal fix. Thanks for pointing > out. > > I have posted patch. > Commit: bac9e0: Kconfig: dra7x: Kconfig based PHYS_64BIT select based on Soc > type
You missed that Masahiro posted one as well that converted all targets :( Can you please grab his and confirm that it fixes the problem as well? Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
