On 15 July 2016 at 02:42, Kever Yang <kever.y...@rock-chips.com> wrote: > RK3399 is a SoC from Rockchip with dual-core Cortex-A72 > and qual-core Cortex-A53 CPU. It supports two USB3.0 > type-C ports and two USB2.0 EHCI ports. Other interfaces > are very like RK3288, the DRAM are 32bit width address > and support address from 0 to 4GB-128MB range. > > Signed-off-by: Kever Yang <kever.y...@rock-chips.com> > --- > > Changes in v3: > Rebase on patch from Andreas: > [PATCH] rockchip: Exclude rk_timer for ARM64 > [PATCH] rockchip: Clean up CPU selection > > Changes in v2: > fix description error on board Kconfig > > arch/arm/Kconfig | 2 - > arch/arm/mach-rockchip/Kconfig | 22 ++++++++- > arch/arm/mach-rockchip/rk3399/Kconfig | 14 ++++++ > arch/arm/mach-rockchip/rk3399/Makefile | 5 ++ > board/rockchip/evb_rk3399/Kconfig | 15 ++++++ > board/rockchip/evb_rk3399/MAINTAINERS | 0 > board/rockchip/evb_rk3399/Makefile | 7 +++ > board/rockchip/evb_rk3399/evb-rk3399.c | 41 +++++++++++++++++ > include/configs/evb_rk3399.h | 24 ++++++++++ > include/configs/rk3399_common.h | 84 > ++++++++++++++++++++++++++++++++++ > 10 files changed, 211 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/mach-rockchip/rk3399/Kconfig > create mode 100644 arch/arm/mach-rockchip/rk3399/Makefile > create mode 100644 board/rockchip/evb_rk3399/Kconfig > create mode 100644 board/rockchip/evb_rk3399/MAINTAINERS > create mode 100644 board/rockchip/evb_rk3399/Makefile > create mode 100644 board/rockchip/evb_rk3399/evb-rk3399.c > create mode 100644 include/configs/evb_rk3399.h > create mode 100644 include/configs/rk3399_common.h
Acked-by: Simon Glass <s...@chromium.org> nits below. [...] > diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h > new file mode 100644 > index 0000000..0bf4f66 > --- /dev/null > +++ b/include/configs/evb_rk3399.h > @@ -0,0 +1,24 @@ > +/* > + * (C) Copyright 2016 Rockchip Electronics Co., Ltd > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +#ifndef __EVB_RK3399_H > +#define __EVB_RK3399_H > + > +#include <configs/rk3399_common.h> > + > + Can you drop the extra blank line? > +#define CONFIG_ENV_IS_IN_MMC > +#define CONFIG_SYS_MMC_ENV_DEV 0 > +/* SPL @ 32k for ~36k > + * ENV @ 96k > + * u-boot @ 128K > + */ Comment style: /* * SPL @ 32k ... */ > +#define CONFIG_ENV_OFFSET (96 * 1024) > + > +#define CONFIG_SYS_WHITE_ON_BLACK > +#define CONFIG_CONSOLE_SCROLL_LINES 10 > + > +#endif [...] Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
