Re: [U-Boot] [PATCH 4/6] efi_loader: Improve .dtb search for arm64

[Tom Rini]

On Tue, Jul 12, 2016 at 06:21:45AM +0200, Andreas Färber wrote:

> On arm64 Linux device trees are organized by SoC vendor. Therefore we
> need to search the vendor subdirectory as well.
> 
> Since the SoC vendor may be different from ${vendor}, introduce a new
> ${soc_vendor}. If this is not set, the behavior remains unchanged.
> 
> Cc: Alexander Graf <ag...@suse.de>
> Signed-off-by: Andreas Färber <afaer...@suse.de>
> ---
>  include/config_distro_bootcmd.h | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
> index eadec2e..8f14457 100644
> --- a/include/config_distro_bootcmd.h
> +++ b/include/config_distro_bootcmd.h
> @@ -113,6 +113,15 @@
>  #define BOOTENV_EFI_SET_FDTFILE_FALLBACK
>  #endif
>  
> +#if defined(CONFIG_ARM64)
> +#define BOOTENV_EFI_SET_FDTFILE_VENDOR                                    \
> +     "if test -n \"${soc_vendor}\"; then "                             \
> +             "setenv efi_dtb_vendor_prefix ${soc_vendor}/; "           \
> +     "fi; "
> +#else

OK.  Looking at the current Linux kernel, it's a given that for arm64 a
DTB will be in a subdirectory, always.  Perhaps we should fix this in
Kconfig and have... CONFIG_FDTFILE_VENDOR_DIRECTORY and set this
correctly per vendor (and yes, eventually there will be some "fun" as
NXP boards will sometimes be in freescale/ and sometimes nxp/ so maybe
try and futureproof ourselves so that we loop over this variable) ?

-- 
Tom

signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot