Hi Simon,
On Sun, Jul 3, 2016 at 8:40 AM, Simon Glass <s...@chromium.org> wrote:
> At present all the hush tests are skipped on sandbox because the test thinks
> that this option is disabled. In fact it has just been renamed.
>
> It might be better to use the full CONFIG_xxx name in tests with
> @pytest.mark.buildconfigspec(), since at present it is not really clear that
> the options are related.
>
> Fixes: f1f9d4fa (hush: complete renaming CONFIG_SYS_HUSH_PARSER to
> CONFIG_HUSH_PARSER)
>
> Signed-off-by: Simon Glass <s...@chromium.org>
Reviewed-by: Teddy Reed <teddy.r...@gmail.com>
> ---
>
> test/py/tests/test_hush_if_test.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/py/tests/test_hush_if_test.py
> b/test/py/tests/test_hush_if_test.py
> index 1eeaa5b..b572538 100644
> --- a/test/py/tests/test_hush_if_test.py
> +++ b/test/py/tests/test_hush_if_test.py
> @@ -109,27 +109,27 @@ def exec_hush_if(u_boot_console, expr, result):
> response = u_boot_console.run_command(cmd)
> assert response.strip() == str(result).lower()
>
> -@pytest.mark.buildconfigspec('sys_hush_parser')
> +@pytest.mark.buildconfigspec('hush_parser')
> def test_hush_if_test_setup(u_boot_console):
> """Set up environment variables used during the "if" tests."""
>
> u_boot_console.run_command('setenv ut_var_nonexistent')
> u_boot_console.run_command('setenv ut_var_exists 1')
>
> -@pytest.mark.buildconfigspec('sys_hush_parser')
> +@pytest.mark.buildconfigspec('hush_parser')
> @pytest.mark.parametrize('expr,result', subtests)
> def test_hush_if_test(u_boot_console, expr, result):
> """Test a single "if test" condition."""
>
> exec_hush_if(u_boot_console, expr, result)
>
> -@pytest.mark.buildconfigspec('sys_hush_parser')
> +@pytest.mark.buildconfigspec('hush_parser')
> def test_hush_if_test_teardown(u_boot_console):
> """Clean up environment variables used during the "if" tests."""
>
> u_boot_console.run_command('setenv ut_var_exists')
>
> -@pytest.mark.buildconfigspec('sys_hush_parser')
> +@pytest.mark.buildconfigspec('hush_parser')
> # We might test this on real filesystems via UMS, DFU, 'save', etc.
> # Of those, only UMS currently allows file removal though.
> @pytest.mark.boardspec('sandbox')
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Awesome, thanks!
--
Teddy Reed V
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
