Hello Heiko,
On Wed, Jun 15, 2016 at 05:34:49PM +0200, Heiko Schocher wrote:
>Hello Peng,
>
>Am 15.06.2016 um 08:15 schrieb Peng Fan:
>>Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.
>>
>>SoCs supports loading U-Boot from different medias to DRAM, such as
>>i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata
>>and etc. For i.MX, imximage will generate different IVT headers according
>>to boot medias.
>>
>>Signed-off-by: Peng Fan <peng....@nxp.com>
>>Cc: Simon Glass <s...@chromium.org>
>>Cc: Heiko Schocher <h...@denx.de>
>>Cc: Joe Hershberger <joe.hershber...@ni.com>
>>Cc: Bin Meng <bmeng...@gmail.com>
>>Cc: Christophe Ricard <christophe-h.ric...@st.com>
>>Cc: Nikita Kiryanov <nik...@compulab.co.il>
>>Cc: Francois Retief <fgret...@spaceteq.co.za>
>>Cc: Tom Rini <tr...@konsulko.com>
>>---
>> common/Kconfig | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>
>Hmm... are there no places where the introduced config options
>already used in config files ?
>
>>diff --git a/common/Kconfig b/common/Kconfig
>>index 4d17b10..a41b670 100644
>>--- a/common/Kconfig
>>+++ b/common/Kconfig
>>@@ -97,6 +97,52 @@ config BOOTSTAGE_STASH_SIZE
>>
>> endmenu
>>
>>+menu "Boot media"
>>+
>>+config SD_BOOT
>>+ bool "Boot from SD"
>>+ default n
>>+ help
>>+ U-Boot image is stored in SD card.
>>+
>>+config NOR_BOOT
>>+ bool "Boot from NOR"
>>+ default n
>>+ help
>>+ U-Boot image is stored in NOR flash.
>
>For example this is already defined in
>
>./board/ti/am335x/Kconfig
My bad.
>
>So I miss at least the lines, which remove this part in your patch,
>else I think, this would lead in a Kconfig error, if we have the
>same symbol in two places ... or?
I did not check other Kconfig files. The idea is to introduce config
entries to support booting uboot from nand/nor/sd/spi and etc.
I'll take care in V2.
>
>>+
>>+config NAND_BOOT
>>+ bool "Boot from NAND"
>>+ default n
>>+ help
>>+ U-Boot image is stored in NAND flash.
>>+
>>+config ONENAND_BOOT
>>+ bool "Boot from ONENAND"
>>+ default n
>>+ help
>>+ U-Boot image is stored in ONENAND flash.
>>+
>>+config SPI_BOOT
>>+ bool "Boot from SPI"
>>+ default n
>>+ help
>>+ U-Boot image is stored in SPI flash.
>>+
>>+config QSPI_BOOT
>>+ bool "Boot from QSPI"
>>+ default n
>>+ help
>>+ U-Boot image is stored in QSPI flash.
>>+
>>+config SATA_BOOT
>>+ bool "Boot from SATA"
>>+ default n
>>+ help
>>+ U-Boot image is stored in SATA.
>>+
>>+endmenu
>>+
>> config BOOTDELAY
>> int "delay in seconds before automatically booting"
>> default 0
>>
>
>may you want to use my brand new tbot testcase [1] for testing, if your
>patch not breaks boards?
I'll try this.
Thanks,
Peng.
>
>bye,
>Heiko
>[1] http://lists.denx.de/pipermail/u-boot/2016-June/258119.html
>--
>DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
