On Wed, Jun 15, 2016 at 1:18 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > > On Tue, Jun 07, 2016 at 11:19:36AM -0700, Steve Rae wrote: > > This file originally came from upstream code. > > > > While retaining the storage abstraction feature, this is the first > > set of the changes required to resync with the > > cmd_flash_mmc_sparse_img() > > in the file > > aboot.c > > from > > > > https://us.codeaurora.org/cgit/quic/la/kernel/lk/plain/app/aboot/aboot.c?h=LE.BR.1.2.1 > > > > Signed-off-by: Steve Rae <s...@broadcom.com> > > Again, please split that in several patches to have one patch > per-change you're doing. > > This is just impossible to review.
And I think you just reinforced the point: this code was so far away from the original upstream code that it is not even recognizable anymore.... Furthermore, I have attempted to split this into several commits -- however, I kept breaking bi-sect so I abandoned that idea. Instead, I extensively reviewed: git log --follow -p -- common/image-sparse.c to determine which changes needed to be retained in U-Boot. This series, therefore, provides working code that is resync'ed with the upstream code, and becomes a platform for planning any future changes. Thanks, Steve > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
