Dear s-paul...@ti.com,
In message <1252508154-28322-1-git-send-email-s-paul...@ti.com> you wrote:
> From: Sandeep Paulraj <s-paul...@ti.com>
>
> This patch removes dependency on the sizes.h header file
> and removes all references to SZ_xx.
...
> --- a/cpu/arm_cortexa8/omap3/mem.c
> +++ b/cpu/arm_cortexa8/omap3/mem.c
> @@ -92,7 +92,7 @@ void make_cs1_contiguous(void)
> u32 size, a_add_low, a_add_high;
>
> size = get_sdr_cs_size(CS0);
> - size /= SZ_32M; /* find size to offset CS1 */
> + size /= (32 << 20); /* find size to offset CS1 */
I have to admit that I don;t understand what you are doing here. But
you can go one step further and write this as:
size >>= 25;
(whic does not make it any easier to unerstand, though).
...
> #ifdef CONFIG_USE_IRQ
> -#define CONFIG_STACKSIZE_IRQ SZ_4K /* IRQ stack */
> -#define CONFIG_STACKSIZE_FIQ SZ_4K /* FIQ stack */
> +#define CONFIG_STACKSIZE_IRQ (128 << 10) /* IRQ stack 4 KiB */
> +#define CONFIG_STACKSIZE_FIQ (128 << 10) /* FIQ stack 4 KiB */
This looks like a copy & paste error to me? At least, the comment and
the code don't match. Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Genitiv ins Wasser, weil's Dativ ist!
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
