On 24/05/16 16:07, Stefano Babic wrote: > Hi Andrew, > > On 20/05/2016 14:22, Andrew Shadura wrote: >> > Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set. >> > >> > Signed-off-by: Andrew Shadura <andrew.shad...@collabora.co.uk> >> > --- >> > board/ge/bx50v3/bx50v3.c | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c >> > index e167cd5..fb112ee 100644 >> > --- a/board/ge/bx50v3/bx50v3.c >> > +++ b/board/ge/bx50v3/bx50v3.c >> > @@ -601,6 +601,8 @@ int board_late_init(void) >> > #ifdef CONFIG_CMD_BMODE >> > add_board_boot_modes(board_boot_modes); >> > #endif >> > + >> > +#ifdef CONFIG_VIDEO_IPUV3 >> > /* We need at least 200ms between power on and backlight on >> > * as per specifications from CHI MEI */ >> > mdelay(250); >> > @@ -615,6 +617,7 @@ int board_late_init(void) >> > gpio_direction_output(LVDS_BACKLIGHT_GP, 1); >> > >> > pwm_enable(0); >> > +#endif > ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that > means your changes works on a out-of-tree version of the board. > > To get this real working, you need to set CONFIG_VIDEO_IPUV3 via > menuconfig, that is outside ge_bx50v3.h.
The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them. -- Cheers, Andrew
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
