On 04/28/2016 02:57 AM, Tom Rini wrote: > On Thu, Apr 28, 2016 at 01:49:38AM +0200, Marek Vasut wrote: >> On 04/13/2016 11:53 PM, Dinh Nguyen wrote: >>> On 04/13/2016 07:24 AM, Marek Vasut wrote: >>>> Add support for board based on the popular Altera Cyclone V SoC. >>>> This board has the following properties: >>>> - 1 GiB of DRAM >>>> - 1 Gigabit ethernet >>>> - 1 USB gadget port >>>> - 1 USB host port with an on-board hub >>>> - 2 QSPI NORs connected to the Cadence QSPI core >>>> - Multiple I2C EEPROMs and one I2C temperature sensor >>>> >>>> Signed-off-by: Marek Vasut <ma...@denx.de> >>>> Cc: Dinh Nguyen <dingu...@opensource.altera.com> >>>> Cc: Chin Liang See <cl...@altera.com> >>>> --- >>> >>> [snip] >>> >>>> --- /dev/null >>>> +++ b/include/configs/socfpga_vining_fpga.h >>>> @@ -0,0 +1,246 @@ >>>> +/* >>>> + * Copyright (C) 2015 Marek Vasut <ma...@denx.de> >>>> + * >>>> + * SPDX-License-Identifier: GPL-2.0+ >>>> + */ >>>> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__ >>>> +#define __CONFIG_SAMTEC_VINING_FPGA_H__ >>>> + >>>> +#include <asm/arch/base_addr_ac5.h> >>>> + >>>> +/* U-Boot Commands */ >>>> +#define CONFIG_SYS_NO_FLASH >>>> +#define CONFIG_DOS_PARTITION >>>> +#define CONFIG_FAT_WRITE >>>> +#define CONFIG_HW_WATCHDOG >>>> + >>>> +#define CONFIG_CMD_ASKENV >>>> +#define CONFIG_CMD_BOOTZ >>>> +#define CONFIG_CMD_CACHE >>>> +#define CONFIG_CMD_DFU >>>> +#define CONFIG_CMD_DHCP >>>> +#define CONFIG_CMD_EEPROM >>>> +#define CONFIG_CMD_EXT4 >>>> +#define CONFIG_CMD_EXT4_WRITE >>>> +#define CONFIG_CMD_FAT >>>> +#define CONFIG_CMD_FS_GENERIC >>>> +#define CONFIG_CMD_GREPENV >>>> +#define CONFIG_CMD_LED >>>> +#define CONFIG_CMD_MII >>>> +#define CONFIG_CMD_MMC >>>> +#define CONFIG_CMD_PING >>>> +#define CONFIG_CMD_USB >>>> +#define CONFIG_CMD_USB_MASS_STORAGE >>>> + >>> >>> With my patch[1], you don't need all of those common configs, all you >>> need is: >>> >>> #define CONFIG_CMD_DFU >>> #define CONFIG_CMD_USB >>> #define CONFIG_CMD_USB_MASS_STORAGE >> >> Well since there are changes in that, are you fine if I pick this board >> as-is for next ? > > You, or anyone else, picking up "old" board ports
This is a new board port, about two weeks old. Technology is moving fast nowadays ;-) > to apply now need to > either ask people to re-spin the series or run moveconfig yourself to > make sure that everything (except CMD_NAND) in cmd/Kconfig is done in > the defconfig and not the config.h file. For example, those last 3 > Kconfig'd right now. CMD_EEPROM and CMD_LED are not I believe. Do you have any example of the moveconfig , so I can try it ? -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
