Matt Waddel wrote: > Hi Scott and Sandeep, > > As long as we're looking at these patches again I had a question about > patch 1 of 2 in this series. > > The following part of the patch added a definition for: > > chip->ecc.read_page = nand_read_page_hwecc_oob_first > > but since there aren't any "break" statements until "case NAND_ECC_SOFT:" > it looks like the chip->ecc.read_page definition ends up being set to: > > chip->ecc.read_page = nand_read_page_swecc. > > Maybe this is explains why things seem to be working???
No, that's OK -- it stops before that on the "if (mtd->writesize >= chip->ecc.size) break;" line (or if that condition is not true, it prints a warning that it is falling back on soft ecc). -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
