On Tue, Mar 22, 2016 at 11:37 PM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 03/22/2016 01:59 PM, Semen Protsenko wrote: >> >> From: Sam Protsenko <semen.protse...@linaro.org> >> >> The description was borrowed from kernel. "tristate" type was changed >> to "bool" (I believe we don't support modules for u-boot yet, right?). >> CONFIG_USB_GADGET requires CONFIG_USB to be defined too, so add it along >> as well. >> >> Some platforms weren't ported though: >> >> include/configs/e2220-1170.h >> include/configs/sunxi-common.h >> include/configs/xilinx_zynqmp.h >> >> CONFIG_USB_GADGET remains in those files as there is no corresponding >> defconfig files for those and I don't want to break anything. > > > That's not true; configs/e2220-1170_defconfig has existed for months. Did > you base this change on the latest u-boot/master?
Yes, you are right. I was assuming that each defconfig file must define CONFIG_TARGET_ in order to tie itself to corresponding include/configs/*.h header. It turns out it's not true and I obviously need to check ".config" file for CONFIG_TARGET_* definition after doing "make ..._defconfig". This is because some defconfig files doesn't have CONFIG_TARGET_ definition, but it's enabled as dependency, or as default value, or whatever. Also I think it's good idea to check modified defconfig files for consistency with "make savedefconfig" rule. I'm going to revise this patch and will submit new version soon. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
