A lot of issues have been found in the error handling with recent additions to the FIT handling code in mkimage. In some cases buffers are not freed or files are not closed. Fix these problems and a few others in existing code that coverity noticed due to recent patches.
Simon Glass (14): mkimage: Fix munmap() call when importing data mkimage: Correct file being closed twice in fit_import_data() mkimage: Correct file being closed twice in fit_extract_data() part_iso: Drop the customer unaligned access functions part_efi: Drop the NULL check on dev_desc in part_print_efi() part_efi: Drop NULL check in part_get_info_efi() mkimage: Close the file when unable to get its size mkimage: Add a missing free() to fit_import_data() mkimage: Fix error path in fit_extract_data() mkimage: Fix missing free() in fit_extract_data() mkimage: Fix missing free() and close() in fit_build() mkimage: Ensure file is closed in fdt_property_file() mkimage: Don't close the file if it wasn't opened usb: Correct return value in usb_stor_info() common/usb_storage.c | 2 +- disk/part_efi.c | 6 +----- disk/part_iso.c | 27 ++++----------------------- tools/fit_image.c | 28 ++++++++++++++++++---------- tools/imagetool.c | 1 + 5 files changed, 25 insertions(+), 39 deletions(-) -- 2.7.0.rc3.207.g0ac5344 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
