On Mon, Mar 14, 2016 at 1:44 PM, Bin Meng <bmeng...@gmail.com> wrote: > On Sat, Mar 12, 2016 at 1:07 PM, Simon Glass <s...@chromium.org> wrote: >> Add a driver which sets up the pin configuration on x86 devices with an ICH6 >> (or later) Platform Controller Hub. >> >> The driver is not in the pinctrl uclass due to some oddities of the way x86 >> devices work: >> >> - The GPIO controller is not present in I/O space until it is set up >> - This is done by writing a register in the PCH >> - The PCH has a driver which itself uses PCI, another driver >> - The pinctrl uclass requires that a pinctrl device be available before any >> other device can be probed >> >> It would be possible to work around the limitations by: >> - Hard-coding the GPIO address rather than reading it from the PCH >> - Using special x86 PCI access to set the GPIO address in the PCH >> >> However it is not clear that this is better, since the pin configuration >> driver does not actually provide normal pin configuration services - it >> simply sets up all the pins statically when probed. While this remains the >> case, it seems better to use a syscon uclass instead. This can be probed >> whenever it is needed, without any limitations. >> >> Also add an 'invert' property to support inverting the input. >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> >> Changes in v2: >> - Use setio_32() instead of setio_le32(), etc. >> >> arch/x86/include/asm/cpu.h | 1 + >> arch/x86/lib/Makefile | 1 + >> arch/x86/lib/pinctrl_ich6.c | 216 >> +++++++++++++++++++++ >> .../gpio/intel,x86-pinctrl.txt | 1 + >> 4 files changed, 219 insertions(+) >> create mode 100644 arch/x86/lib/pinctrl_ich6.c >> > > Reviewed-by: Bin Meng <bmeng...@gmail.com>
applied to u-boot-x86/next, thanks! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
