Hi Adam,
On 02.03.2016 13:38, Adam Ford wrote:
> A few boards still use ns16550_platdata structures, but assume the structure
> is going to be in a specific order. By explicitly naming each entry,
> this should also help 'future-proof' in the event the structure changes.
>
> Tested on the Logic PD Torpedo + Wireless.
>
> I only changed a handful of devices that used the same syntax as the Logic
> board. Appologies if I missed one or stepped on toes. Thanks to Derald Woods
> and Alexander Graf.
>
> Signed-off-by: Adam Ford <aford...@gmail.com>
>
> V5: Add fix to arch/arm/cpu/arm926ejs/lpc32xx/devices.c
>
> V4: Fix subject heading
>
> V3: Remove reg_offset out in all the structs. It was reverted out, and and if
> it did exist, it would get initialized to 0 by default.
>
> V2: I hastily copy-pasted the boards without looking at the UART number.
> This addresses 3 boards that use UART3 and not UART1.
> ---
> arch/arm/cpu/arm926ejs/lpc32xx/devices.c | 8 ++++----
> board/isee/igep00x0/igep00x0.c | 6 +++---
> board/logicpd/omap3som/omap3logic.c | 6 +++---
> board/logicpd/zoom1/zoom1.c | 6 +++---
> board/overo/overo.c | 6 +++---
> board/quipos/cairo/cairo.c | 6 +++---
> board/ti/beagle/beagle.c | 6 +++---
> board/timll/devkit8000/devkit8000.c | 6 +++---
> 8 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> index b6db23e..399b07c 100644
> --- a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> +++ b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> @@ -45,10 +45,10 @@ void lpc32xx_uart_init(unsigned int uart_id)
>
> #if !CONFIG_IS_ENABLED(OF_CONTROL)
> static const struct ns16550_platdata lpc32xx_uart[] = {
> - { UART3_BASE, 2, CONFIG_SYS_NS16550_CLK },
> - { UART4_BASE, 2, CONFIG_SYS_NS16550_CLK },
> - { UART5_BASE, 2, CONFIG_SYS_NS16550_CLK },
> - { UART6_BASE, 2, CONFIG_SYS_NS16550_CLK },
> + { .base = UART3_BASE, .reg_shift = 2, .clock = CONFIG_SYS_NS16550_CLK },
> + { .base = UART4_BASE, .reg_shift = 2, .clock = CONFIG_SYS_NS16550_CLK },
> + { .base = UART5_BASE, .reg_shift = 2, .clock = CONFIG_SYS_NS16550_CLK },
> + { .base = UART6_BASE, .reg_shift = 2, .clock = CONFIG_SYS_NS16550_CLK },
> };
For LPC32xx part
Acked-by: Vladimir Zapolskiy <v...@mleia.com>
--
With best wishes,
Vladimir
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
