Hi Stephen, On Thu, Feb 25, 2016 at 12:48 AM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 02/23/2016 10:09 PM, Bin Meng wrote: >> >> Introduce CONFIG_RTL8169 in Kconfig and move over boards' defconfig >> to use that. > > > You didn't Cc any maintainers of these files... I only accidentally noticed > this patch. >
Sorry about that. Will do next time. >> configs/beaver_defconfig | 1 + >> configs/cardhu_defconfig | 1 + >> configs/chromebox_panther_defconfig | 1 + >> configs/jetson-tk1_defconfig | 1 + >> configs/minnowmax_defconfig | 1 + >> configs/p2371-2180_defconfig | 1 + >> configs/trimslice_defconfig | 1 + >> drivers/net/Kconfig | 6 ++++++ >> include/configs/beaver.h | 1 - >> include/configs/cardhu.h | 1 - >> include/configs/chromebox_panther.h | 1 - >> include/configs/jetson-tk1.h | 1 - >> include/configs/minnowmax.h | 1 - >> include/configs/p2371-2180.h | 1 - >> include/configs/r7780mp.h | 1 - >> include/configs/sh7785lcr.h | 1 - >> include/configs/trimslice.h | 1 - > > > I don't see any file in configs/ that was updated to account for the > removals from r7780mp.h and sh7785lcr.h. Is that intentional? > This was done by moveconfig tool automatically. I may double check this. >> diff --git a/include/configs/beaver.h b/include/configs/beaver.h >> index c672a8e..21ee954 100644 >> --- a/include/configs/beaver.h >> +++ b/include/configs/beaver.h >> @@ -64,7 +64,6 @@ >> #define CONFIG_CMD_PCI >> >> /* PCI networking support */ >> -#define CONFIG_RTL8169 >> >> /* General networking support */ >> #define CONFIG_CMD_DHCP > > > The comment "PCI networking support" and the blank line before it should be > removed too. This comment applies to a number of the other files too. Will remove that in v2. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
