Hi Dirk, On Fri, 2009-08-21 at 15:00 +0200, Dirk Behme wrote: > Frederik Kriewitz wrote: > > Jean-Christophe asked me to move it out of the omap3 "vendor" directory: > > > > On 10:55 Thu 20 Aug , Frederik Kriewitz wrote: > >> On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe > >> PLAGNIOL-VILLARD<plagn...@jcrosoft.com> wrote: > >>>> board/omap3/devkit8000/Makefile | 52 +++++ > >>>> board/omap3/devkit8000/config.mk | 35 ++++ > >>>> board/omap3/devkit8000/devkit8000.c | 124 ++++++++++++ > >>>> board/omap3/devkit8000/devkit8000.h | 373 > >>>> +++++++++++++++++++++++++++++++++++ > >>> no need board are allow in board/omap3 > >>> please create your own vendor dirent or just put it in board/ > >> What do you mean with that? > > board/devkit8000/devkit8000.h > > or board/embedinfo/devkit8000/devkit8000.h > > > > I'm confused, where am I supposed to use omap3 and where not? > > Yes, sometimes it can be confusing ;) > > From earlier discussions I understood that Jean-Christophe doesn't like > > board/omap3/ > > I'm not totally sure what he actually wants, but I think something like > > board/ti/omap3 > board/ti/omap2 > board/ti/omap1 > board/ti/davinci > > etc. (e.g. like board/atmel).
My understanding is that the board/ layout should be "/board/<board vendor or board name>/...". So even though the Frederik's board has a TI OMAP3 cpu, he shouldn't put it in board/ti or board/omap3 since neither TI nor OMAP3 made the DevKit8000. I believe all the boards in board/atmel are made by atmel and use atmel cpus, same with board/freescale. But if anyone else makes a custom atmel or freescale-based board, it should not go in board/atmel or board/freescale. For example, there are mpc8548, mpc8572, mpc8548, and amcc440-based boards in board/xes, but they are all made by the X-ES company. Jean-Christophe is saying you should put your board in either: board/devkit8000/ or, if your company (embedinfo?) plans on adding more than just the devkit8000, put it in: board/embedinfo/devkit8000 board/embedinto/<future_board_x> > While I don't care what we use, like with other discussions we should > do it consistent. That is, having already x boards in omap3 and now > adding the next board somewhere else isn't ok. As long as we don't > have the new directory layout, new boards should use the old one. If > we want an other directory layout, we should *first* move all existing > boards to the other directory (ideally doing this directly in git). > *Then* new patches can and have to use this new layout. I agree that other boards currently in board/omap3 should be moved to an appropriate board/<board vendor or board name> directory in the long run, ideally sooner rather than later:) That being said, I think it would make sense to put the devkit8000 in either board/devkit8000/ or board/embedinfo/devkit8000 now as that is the "correct" place for it. > Conclusion: Until we don't have an other directory layout, I'm fine > with board/omap3/devkit8000 Doesn't really matter to me, just thought I'd mention my $.02 about how thing should be organized in the long run. Best, Peter _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
