Hi Mugunthan, On 4 February 2016 at 08:09, Mugunthan V N <[email protected]> wrote: > Hi Simon > > I tried to use patman with a sample commit, below is the commit > with the tag patmantest > > Commit: > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > $ git show patmantest > tag patmantest > Tagger: Mugunthan V N <[email protected]> > Date: Thu Feb 4 11:51:48 2016 +0530 > > Series-to: me > Series-prefix: RFC > Cover-letter: > Unified command execution in one place > > At present two parsers have similar code to execute commands. Also > cmd_usage() is called all over the place. This series adds a single > function which processes commands called cmd_process(). > END > > commit 02c23a9b585d91272befb8fe43d21fe52e1fd139 > Author: Mugunthan V N <[email protected]> > Date: Mon Jan 18 14:17:43 2016 +0530 > > defconfig: dra72_evm: enable disk driver model > > Enable disk driver model for dra72_evm as dwc_ahci supports > driver model > > Signed-off-by: Mugunthan V N <[email protected]> > Reviewed-by: Tom Rini <[email protected]> > > diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig > index 32d1dc1..7ff2a4e 100644 > --- a/configs/dra72_evm_defconfig > +++ b/configs/dra72_evm_defconfig > @@ -24,3 +24,5 @@ CONFIG_DM_SPI=y > CONFIG_DM_SPI_FLASH=y > CONFIG_TIMER=y > CONFIG_OMAP_TIMER=y > +CONFIG_DISK=y > +CONFIG_DWC_AHCI=y > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > But when I patman -n, it throws below error > > $ ./tools/patman/patman -n > Cleaned 1 patches > total: 0 errors, 0 warnings, 0 checks, 5 lines checked > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE > PREFER_ETHER_ADDR_COPY USLEEP_RANGE
I'm not sure where this message comes from - I don't see it. I suppose it is checkpatch.pl. > > 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style > problems and is ready for submission. > Traceback (most recent call last): > File "./tools/patman/patman", line 158, in <module> > options.add_maintainers) > File > "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", > line 222, in MakeCcFile > raise_on_error=raise_on_error) > File > "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", > line 321, in BuildEmailList > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > File > "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", > line 495, in LookupEmail > raise ValueError, msg > ValueError: Alias 'defconfig' not found This means it couldn't find the alias 'defconfig' :-) You have a defconfig: tag in your subject so patman will Cc that alias. Since it doesn't exist you get an error. You can use the -t option to ignore bad takes, or add an alias to .patman, like this: defconfig: Fred Bloggs <[email protected]> Also see 'Where Patches Are Sent' in the README. > > > Then I tried with patman setting ignore_errors: True and > process_tags: False, then the out seems fine but the tag > is not processed. Do you find any thing I missed? Well only that you told it not to process the tag. I don't think it's a good idea to add those settings. Try 'patman -nt' to use tags if they can be found, and ignore tags that can't be found. > > Output with modified patman settings: > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > $ ./tools/patman/patman -n > Cleaned 1 patches > total: 0 errors, 0 warnings, 0 checks, 5 lines checked > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE > PREFER_ETHER_ADDR_COPY USLEEP_RANGE > > 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style > problems and is ready for submission. > No recipient. > Please add something like this to a commit > Series-to: Fred Bloggs <[email protected]> > Or do something like this > git config sendemail.to [email protected] > Dry run, so not doing much. But I would do this: > > Send a total of 1 patch with no cover letter. > 0001-defconfig-dra72_evm-enable-disk-driver-model.patch > Cc: [email protected] > Cc: Lokesh Vutla <[email protected]> > > Version: None > Prefix: None > > Here is my patman config > $ cat ~/.patman > [alias] > me: Mugunthan V N <[email protected]> > > [settings] > ignore_errors: True > process_tags: False > verbose: True > > Regards > Mugunthan V N Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
