Dear Poonam Aggrwal,
In message <1250775054-20418-1-git-send-email-poonam.aggr...@freescale.com> you
wrote:
> * Added PCIe support for P1 P2 RDB
> * Calls the fsl_pci_init_port function to initialize all the PCIe ports
> on the board.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggr...@freescale.com>
> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
> ---
> - applies on git.denx.de/u-boot-mpc85xx.git branch->next
> board/freescale/p1_p2_rdb/Makefile | 1 +
> board/freescale/p1_p2_rdb/pci.c | 112
> ++++++++++++++++++++++++++++++++++++
> include/configs/P1_P2_RDB.h | 6 ++
> 3 files changed, 119 insertions(+), 0 deletions(-)
> create mode 100644 board/freescale/p1_p2_rdb/pci.c
>
> diff --git a/board/freescale/p1_p2_rdb/Makefile
> b/board/freescale/p1_p2_rdb/Makefile
> index 9107263..c366f7c 100644
> --- a/board/freescale/p1_p2_rdb/Makefile
> +++ b/board/freescale/p1_p2_rdb/Makefile
> @@ -27,6 +27,7 @@ LIB = $(obj)lib$(BOARD).a
> COBJS-y += $(BOARD).o
> COBJS-y += law.o
> COBJS-y += tlb.o
> +COBJS-$(CONFIG_PCI) += pci.o
> COBJS-y += ddr.o
Please (make and) keep list sorted.
...
> +void ft_pci_board_setup(void *blob)
> +{
> +#ifdef CONFIG_PCIE2
> + ft_fsl_pci_setup(blob, "pci1", &pcie2_hose);
PCIE2 ... pci1 ... pcie2 ???
> +#endif
> +#ifdef CONFIG_PCIE1
> + ft_fsl_pci_setup(blob, "pci2", &pcie1_hose);
PCIE1 ... pci2 ... pcie1 ???
This looks broken to me?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer to reality.
-- Albert Einstein
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
