Hi Peter, On Wed, Feb 3, 2016 at 2:48 PM, Peter Hanson <pet...@google.com> wrote: > The commit below added default format flags for common net env vars: > http://git.denx.de/?p=u-boot.git;a=commit;h=c0a93440a7cb50843510549d9943a4fba211f0f2 > > Alas, it seems to specify IP format for vlan tags, which are > traditionally simple 12-bit integers. > > So for instance, nvlan=1 should select native VLAN 1, but is now > rejected, whereas nvlan=0.0.0.1 is accepted.
Yeah, that was simply mis-typed. The intention was for them to be tagged as "d" for decimal. > The suspect entries were still present at head when I checked a few minutes > ago. > > As a code-slayer, my first instinct is to delete these entries. > However, these symbols do have call-backs. They could be marked as > integers if every such metavariable should have a format. It is preferable to have format checks on variables that are intended to be interpreted by U-Boot as a specific format. Thanks, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
