Hi Albert, On 31 January 2016 at 09:51, Albert ARIBAUD <albert.u.b...@aribaud.net> wrote: > Hello Simon, > > On Thu, 19 Nov 2015 20:29:11 -0700, Simon Glass <s...@chromium.org> > wrote: >> Hi Albert, >> >> On 13 November 2015 at 19:35, Simon Glass <s...@chromium.org> wrote: >> > On 9 November 2015 at 14:36, Albert ARIBAUD <albert.u.b...@aribaud.net> >> > wrote: >> >> Hello Simon, >> >> >> >> On Mon, 9 Nov 2015 12:24:55 -0800, Simon Glass <s...@chromium.org> wrote: >> >>> On 9 November 2015 at 06:19, Albert ARIBAUD <albert.u.b...@aribaud.net> >> >>> wrote: >> >>> > A patman series with a 'Series-notes' section causes >> >>> > buildman to crash with: >> >>> > >> >>> > self.series.notes += self.section >> >>> > TypeError: cannot concatenate 'str' and 'list' objects >> >>> > >> >>> > Fix by initializing series.notes as a one-element array >> >>> > rathen than a scalar. >> >>> > >> >>> > Signed-off-by: Albert ARIBAUD <albert.u.b...@aribaud.net> >> >>> > --- >> >>> > >> >>> > tools/patman/series.py | 2 +- >> >>> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >>> >> >>> Acked-by: Simon Glass <s...@chromium.org> >> >> >> >> Note: just spotted a typo, 'rathen' instead of 'rather'. If this patch >> >> gets applied, please fix that on-the-fly. >> >> >> >> Amicalement, >> >> -- >> >> Albert. >> > >> > Fixed typo and >> > >> > Applied to u-boot-dm, thanks! >> >> Hmm, actually I've had to drop this as it breaks 'Series-version'. >> That currently does not expect a list. > > Hmm, I can't reproduce this here. How do you trigger the Series-version > break?
I created a commit with a Series-version: in it. Then, running patman gives a run-time error because it is expecting a single value, not an array. > >> I wonder if Series-notes needs a special case, instead? >> >> Regards, >> Simon > > Amicalement, > -- > Albert. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
