On Wed, Jan 13, 2016 at 04:24:42PM +0100, Stefan Roese wrote: > Hi Tom, > > On 13.01.2016 16:13, Tom Rini wrote: > >On Fri, Dec 25, 2015 at 02:41:25PM +0100, Phil Sutter wrote: > > > >>This adds support for the MV78230 based DS414 NAS by Synology. The > >>relevant bits have been extracted from the 'synogpl-5004-armadaxp' > >>package Synology kindly published, garnished with a fair amount of > >>trial-and-error. > > > >So, for the code: > > > >Reviewed-by: Tom Rini <tr...@konsulko.com> > > > >But most of what follows should be in the "log" side, ie after the --- > >rather than the message itself. This can be fixed when applying, but if > >you end up needing to respin please reword this part, thanks! > > I've already prepared a git branch, with all the pending Marvell > mvebu related patches included. For Luka to pull from into the > official Marvell U-boot git repo. And I've added Phil's patches > as well. My personal feeling is, that all this additional text > could be quite useful. That's why I would like to keep it in. > But if you really feel that we should remove it, then I can > definitely drop those passages. > > Just let me know what you think.
I'll live with it in the commit log, thanks. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot