Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:42 Wed 12 Aug , Tom Rix wrote: > >> v7_flush_dcache_all, because it depends on omap ROM code is not >> generic. Rename the function to 'invalidate_dcache' and move it >> to the omap cpu directory. >> >> <snip>
> for the l2 cache ACK > for the invalidate cache NACK > > we do not need to call the rom code as the armv7 flush cache work fine > on omap3 and duplicate armv7 code with really few code (non needed) no > > Jean, I disagree on the invalidate cache NAK. First, you were fine with change earlier From an earlier email. flush_dcache was chosen to match other boards/cpu's and one of the > main reasons for this change. If Jean is ok changing flush_dcache > to invalidate_dcache, I will make that change too. invalidate_dcache is fine for me Best Regards, J. Second, removing the invalidate_dcache will change OMAP. This is different from this change which is really just moving code around. As a separate change, it should be submitted as a new change. Without moving invalidate_dcache and the l2_* functions to cache.S, we are so close to where we are now, with l2_* in cache.c that I am not sure what you really want. Tom > Best Regards, > J. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
