On Wed, Aug 12, 2009 at 11:15:26PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : > On 18:10 Wed 12 Aug , Albin Tonnerre wrote: > > Currently, at91/led.c only provides _on and _off functions for green, > > yellow and red LEDs. This patch provides a generic coloured_LED_init > > function, which is a first step towards getting rid of the > > board-specific (and duplicated) board/*/*/led.c files on at91 > > This patch alos adds similar support for blue LEDs, mostly for the sake > > of completeness. > > > we do need to stop adding more and more specific led api > we do need to have a common api that we can use on any arch for c & asm
This does not *add* specific LED API, it merely implements the existing one. There /is/ a common led API, which currently has no support for ARM, as you probably know. Does you message mean you'd accept a patch which drops the coloured-LED API (whose only user is currently ARM) and use the one described in include/status_led.h ? Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
