On Friday, December 11, 2015 at 08:49:13 PM, Eric Nelson wrote: > On 12/11/2015 10:33 AM, Marek Vasut wrote: > > On Friday, December 11, 2015 at 03:58:35 PM, Stefano Babic wrote: > >> Hi Eric, > > >> On 11/12/2015 15:40, Eric Nelson wrote: > ... > > >>>> + /* > >>>> + * Check for BMODE if serial downloader is enabled > >>>> + * BOOT_MODE - see IMX6DQRM Table 8-1 > >>>> + */ > >>>> + if ((((bmode >> 24) & 0x03) == 0x01) || /* Serial Downloader */ > >>> > >>> I think Marek will have a problem with the yoda conditional: > >>>> + (gpr10_boot && (1 == reg))) > >> > >> I fix it in V3 before Marek complains :-). I do not like yoda > >> conditions, too. > > > > Problem, I have ;-) > > Even this week? > > You guys have never had the compiler catch an erroneous assignment > like this one: > > if (i = 1) > ... > > I got in this habit many years ago after reading "Code Complete", > and it's saved me many a time...
The compiler should really be catching these. The condition if (1 == foo) is extremely unnatural. > I need to figure out how to get checkpatch.pl to watch it for me > when pushing stuff up-stream. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
