HI Stuart
> -----Original Message----- > From: York Sun [mailto:york...@freescale.com] > Sent: Saturday, December 05, 2015 1:35 AM > To: Yoder Stuart-B08248 <stuart.yo...@freescale.com>; Kushwaha > Prabhakar-B32579 <prabha...@freescale.com> > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH] driver: net: fsl-mc: remove MC firmware version check > > Prabhakar, > > On 12/03/2015 01:14 PM, Stuart Yoder wrote: > > The MC version numbers provide no meaningful information about binary > > interface compatibility, so remove the check which refuses to start > > the MC unless a specific version is found. > > > > Version checking is supposed to be done at the individual object > > level, and individual drivers are responsible for their own version > > checking. > > > > Signed-off-by: Stuart Yoder <stuart.yo...@freescale.com> > > --- > > drivers/net/fsl-mc/mc.c | 13 ------------- > > 1 file changed, 13 deletions(-) > > > > diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index > > e1a02d1..bac4610 100644 > > --- a/drivers/net/fsl-mc/mc.c > > +++ b/drivers/net/fsl-mc/mc.c > > @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr) > > goto out; > > } > > > > - if (MC_VER_MAJOR != mc_ver_info.major) { > > - printf("fsl-mc: ERROR: Firmware major version mismatch > (found: %d, expected: %d)\n", > > - mc_ver_info.major, MC_VER_MAJOR); > > - printf("fsl-mc: Update the Management Complex > firmware\n"); > > - > > - error = -ENODEV; > > - goto out; > > - } > > - > > - if (MC_VER_MINOR != mc_ver_info.minor) > > - printf("fsl-mc: WARNING: Firmware minor version mismatch > (found: %d, expected: %d)\n", > > - mc_ver_info.minor, MC_VER_MINOR); > > - > > printf("fsl-mc: Management Complex booted (version: %d.%d.%d, > boot status: %#x)\n", > > mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision, > > reg_gsr & GSR_FS_MASK); > > > > Are you OK with this change? As per my understanding, version of individual components are fix in a major MC release. Are you saying, there is possibility of object version change in a minor MC release? --Prabhakar _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
