On 12/04/2015 10:25 AM, Simon Glass wrote:
Hi Stephen,

On 4 December 2015 at 10:16, Stephen Warren <swar...@wwwdotorg.org> wrote:
On 12/04/2015 08:58 AM, Simon Glass wrote:

These were added by mistake in commit fde7e189. They cause a warning when
configuring the boards. Remove them.


Patches 1-3,
Tested-by: Stephen Warren <swar...@nvidia.com>

It would be useful to include the appropriate Fixes: tags in the commit
message, and this issue was originally:

Reported-by: Kevin Hilman <khil...@linaro.org>

Thanks - what Fixes tags?

I'd expect the following at the start of the "signature paragraph":

Fixes: fde7e18938d8 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")

Referencing in a standard way the commits that caused the bug that this patch fixes makes researching bug/commit history easier. Admittedly that tag is something from the Linux kernel development process and isn't mandated by U-Boot's process, but I think it's a good idea that's worth following.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to