Hi Stefan, Simon, On Mon, Oct 19, 2015 at 7:16 AM, Simon Glass <s...@chromium.org> wrote: > On 29 September 2015 at 23:00, Stefan Roese <s...@denx.de> wrote: >> The current "simple" address translation simple_bus_translate() is not >> working on some platforms (e.g. MVEBU). As here more complex "ranges" >> properties are used in many nodes (multiple tuples etc). This patch >> enables the optional use of the common fdt_translate_address() function >> which handles this translation correctly. >> >> Signed-off-by: Stefan Roese <s...@denx.de> >> Cc: Simon Glass <s...@chromium.org> >> Cc: Bin Meng <bmeng...@gmail.com> >> Cc: Marek Vasut <ma...@denx.de> >> Cc: Masahiro Yamada <yamada.masah...@socionext.com> >> Cc: Stephen Warren <swar...@nvidia.com> >> Cc: Lukasz Majewski <l.majew...@samsung.com> >> --- >> v3: >> - Rebased on current U-Boot version >> - Added Stephen and Lukasz to Cc >> >> v2: >> - Rework code a bit as suggested by Simon. Also added some comments >> to make the use of the code paths more clear. >> >> drivers/core/Kconfig | 30 ++++++++++++++++++++++++++++++ >> drivers/core/device.c | 20 ++++++++++++++++++++ >> 2 files changed, 50 insertions(+) > > Applied to u-boot-dm, thanks!
When testing Simon's patch [1], I found PCI UART on Intel Crown Bay no longer works. git bisect leads to this commit. Somehow I missed this patch before although I see the commit message get me cc'ed but the email did not bring to my attention. I see this patch introduced OF_TRANSLATE and by default set it to y. This makes the code logic in dev_get_addr() go through fdt_translate_address(), which breaks the things. Should we set OF_TRANSLATE to n by default? If set to y, this requires dts to have complete ranges property everywhere. [1]: http://patchwork.ozlabs.org/patch/549799/ Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
