Hi, On 27.11.2015 06:27, Hannes Schmelzer wrote: > hello, > > The ps7_init_gpl.c is some output from the xilinix vivado tool as > hardware handoff. > We compile this into our SPL. > > My question is how to deal with "scripts/checkpatch.pl" on this file. > The scripts throughs a lot of errors. > > # scripts/checkpatch.pl -f > board/xilinx/zynq/ZC702_hw_platform/ps7_init_gpl.c > otal: 13009 errors, 13130 warnings, 14 checks, 13307 lines checked > > NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or > scripts/cleanfile > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE > USLEEP_RANGE > > board/xilinx/zynq/ZC702_hw_platform/ps7_init_gpl.c has style problems, > please review.
I have recommended this sequence [u-boot]$ uncrustify --no-backup board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c Parsing: board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c as language C [u-boot]$ ./scripts/Lindent board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c [u-boot]$ ./scripts/checkpatch.pl -f board/xilinx/zynq/ZC706_hw_platform/ps7_init_gpl.c --max-line-length=200 And fix the rest by hand. That's what Nathan has done for adding zybo files. Coding style should be hopefully fixed in 2016.1 but we will see as always. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
# # uncrustify config file for the linux kernel # # http://uncrustify.sourceforge.net/config.txt indent_with_tabs = 2 # 1=indent to level only, 2=indent with tabs input_tab_size = 8 # original tab size output_tab_size = 8 # new tab size indent_columns = output_tab_size indent_label = 1 # pos: absolute col, neg: relative column # # inter-symbol newlines # nl_enum_brace = remove # "enum {" vs "enum \n {" nl_union_brace = remove # "union {" vs "union \n {" nl_struct_brace = remove # "struct {" vs "struct \n {" nl_do_brace = remove # "do {" vs "do \n {" nl_if_brace = remove # "if () {" vs "if () \n {" nl_for_brace = remove # "for () {" vs "for () \n {" nl_else_brace = remove # "else {" vs "else \n {" nl_while_brace = remove # "while () {" vs "while () \n {" nl_switch_brace = remove # "switch () {" vs "switch () \n {" nl_brace_while = remove # "} while" vs "} \n while" - cuddle while nl_brace_else = remove # "} else" vs "} \n else" - cuddle else nl_func_var_def_blk = 1 nl_fcall_brace = remove # "list_for_each() {" vs "list_for_each()\n{" nl_fdef_brace = add # "int foo() {" vs "int foo()\n{" # nl_after_return = TRUE; # nl_before_case = 1 # # Source code modifications # mod_paren_on_return = remove # "return 1;" vs "return (1);" mod_full_brace_if = remove # "if (a) a--;" vs "if (a) { a--; }" mod_full_brace_for = remove # "for () a--;" vs "for () { a--; }" mod_full_brace_do = remove # "do a--; while ();" vs "do { a--; } while ();" mod_full_brace_while = remove # "while (a) a--;" vs "while (a) { a--; }" mod_full_brace_nl = 3 # don't remove if more than 3 newlines # # inter-character spacing options # # sp_return_paren = force # "return (1);" vs "return(1);" sp_sizeof_paren = remove # "sizeof (int)" vs "sizeof(int)" sp_before_sparen = force # "if (" vs "if(" sp_after_sparen = force # "if () {" vs "if (){" sp_after_cast = remove # "(int) a" vs "(int)a" sp_inside_braces = add # "{ 1 }" vs "{1}" sp_inside_braces_struct = add # "{ 1 }" vs "{1}" sp_inside_braces_enum = add # "{ 1 }" vs "{1}" sp_assign = add sp_arith = add sp_bool = add sp_compare = add sp_assign = add sp_after_comma = add sp_func_def_paren = remove # "int foo (){" vs "int foo(){" sp_func_call_paren = remove # "foo (" vs "foo(" sp_func_proto_paren = remove # "int foo ();" vs "int foo();" # # Aligning stuff # align_with_tabs = TRUE # use tabs to align align_on_tabstop = TRUE # align on tabstops # align_keep_tabs = true align_enum_equ_span = 4 # '=' in enum definition # align_nl_cont = TRUE # align_var_def_span = 2 # align_var_def_inline = TRUE # align_var_def_star = FALSE # align_var_def_colon = TRUE # align_assign_span = 1 align_struct_init_span = 3 # align stuff in a structure init '= { }' align_right_cmt_span = 3 # align_pp_define_span = 8; # align_pp_define_gap = 4; # cmt_star_cont = FALSE # indent_brace = 0 cmt_cpp_to_c = TRUE
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
