On Aug 6, 2009, at 2:33 PM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <1249573913-1451-1-git-send-email- > ga...@kernel.crashing.org> you wrote: >> We move all IO addressed (CCSR, localbus, PCI) above the 4G boundary >> to allow for larger memory sizes. >> >> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> >> --- >> Makefile | 8 ++++- >> include/configs/MPC8536DS.h | 78 +++++++++++++++++++++++++++++++++ >> ++++----- >> 2 files changed, 75 insertions(+), 11 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 54c0b67..8ebdd42 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -2406,8 +2406,14 @@ vme8349_config: unconfig >> ATUM8548_config: unconfig >> @$(MKCONFIG) $(@:_config=) ppc mpc85xx atum8548 >> >> +MPC8536DS_36BIT_config \ >> MPC8536DS_config: unconfig >> - @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale >> + @mkdir -p $(obj)include >> + @if [ "$(findstring _36BIT_,$@)" ] ; then \ >> + echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \ >> + $(XECHO) "... enabling 36-bit physical addressing." ; \ >> + fi >> + @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescale > > Argh... You know that I hate such long script-like parts in the top > level Makefile. Please add such logic to the board config file > instead.
Do you have an example of doing this for a single config option like this? I'm happy to fix things. Should I have a: include/configs/MPC8536DS_36BIT.h that looks like: #ifndef MPC8536DS_36BIT_H #define MPC8536DS_36BIT_H #define CONFIG_PHYS_64BIT #include <configs/MPC8536DS.h> #endif or is there some other solution to this problem? - k _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot