Re: [U-Boot] [PATCH 1/1] fsl_qspi: Pet the watchdog while reading/writing

[York Sun]

On 11/04/2015 12:19 AM, Alexander Stein wrote:
> When reading a large blob. e.g. a linux kernel (several MiBs) a watchdog
> timeout might occur meanwhile. So pet the watchdog while operating on
> the flash.

Alexander,

On which platform was this watchdog issue found?

> 
> Signed-off-by: Alexander Stein <alexander.st...@systec-electronic.com>
> ---
>  drivers/spi/fsl_qspi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
> index ed39114..feec3e8 100644
> --- a/drivers/spi/fsl_qspi.c
> +++ b/drivers/spi/fsl_qspi.c
> @@ -13,6 +13,7 @@
>  #include <linux/sizes.h>
>  #include <dm.h>
>  #include <errno.h>
> +#include <watchdog.h>
>  #include "fsl_qspi.h"
>  
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -527,6 +528,8 @@ static void qspi_op_read(struct fsl_qspi_priv *priv, u32 
> *rxbuf, u32 len)
>       to_or_from = priv->sf_addr + priv->cur_amba_base;
>  
>       while (len > 0) {
> +             WATCHDOG_RESET();
> +
>               qspi_write32(priv->flags, &regs->sfar, to_or_from);
>  
>               size = (len > RX_BUFFER_SIZE) ?
> @@ -574,6 +577,8 @@ static void qspi_op_write(struct fsl_qspi_priv *priv, u8 
> *txbuf, u32 len)
>  
>       status_reg = 0;
>       while ((status_reg & FLASH_STATUS_WEL) != FLASH_STATUS_WEL) {
> +             WATCHDOG_RESET();
> +
>               qspi_write32(priv->flags, &regs->ipcr,
>                            (SEQID_WREN << QSPI_IPCR_SEQID_SHIFT) | 0);
>               while (qspi_read32(priv->flags, &regs->sr) & QSPI_SR_BUSY_MASK)
> 

York
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot