On Friday 06 November 2015 05:37 PM, Simon Glass wrote:
> Hi Mugunthan,
>
> On 4 November 2015 at 01:16, Mugunthan V N <mugunthan...@ti.com> wrote:
>> Prepare driver for DM conversion.
>>
>> Signed-off-by: Mugunthan V N <mugunthan...@ti.com>
>> ---
>> drivers/spi/ti_qspi.c | 287
>> ++++++++++++++++++++++++++++----------------------
>> 1 file changed, 161 insertions(+), 126 deletions(-)
>
> This looks OK except for the lack of a change log and one thing below.
>>
>> diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
>> index 44c5762..003df80 100644
>> --- a/drivers/spi/ti_qspi.c
>> +++ b/drivers/spi/ti_qspi.c
>> @@ -28,6 +28,7 @@
>> #define QSPI_3_PIN BIT(18)
>> #define QSPI_RD_SNGL BIT(16)
>> #define QSPI_WR_SNGL (2 << 16)
>> +#define QSPI_RD_DUAL (7 << 16)
>> #define QSPI_INVAL (4 << 16)
>> #define QSPI_RD_QUAD (7 << 16)
>> /* device control */
>> @@ -89,46 +90,16 @@ struct ti_qspi_regs {
>> struct ti_qspi_priv {
>> struct spi_slave slave;
>
> This should not be present when driver model is used. Can you put an
> #ifdef around it and store anything else you need directly in the
> structure, rather than using struct spi_slave?
Yeah, will do it in next version.
>
>> struct ti_qspi_regs *base;
>> + void *ctrl_mod_mmap;
>> unsigned int mode;
>> u32 cmd;
>> u32 dc;
>> + u32 num_cs;
>> + u32 rx_bus_width;
>> };
>>
Regards
Mugunthan V N
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
