Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <20090803121748.gg15...@game.jcrosoft.org> you wrote:
>
> > > > +#define CONFIG_SYS_MALLOC_LEN (0x10000 + 256 * 1024)
> > > please do not mix hexa and decimal
> I've as there is other think to fix otherwise I'll not have ask
> >
> > Please be reasonable. This is a perfectly valid and easy to read
> > notation. I see no reason to change this - anything else would
> > probably be much harder to read.
Please do not insist in changing this. No matter how you wrote it,
"0x10000 + 0x100 * 0x400" or "0x10000 + 0x40000" or "65536 + 256 *
1024" or "65536 + 262144" - all thesde forms are more difficult to
parse and give less insight into what is intended.
I say: there is no reason to change this.
> > > > +#define CONFIG_LOADADDR 0xa0800000 /* loadaddr env
> > > > var */
> > > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
> > > why 2?
> >
> > Because they do different things.
> I've take a look they do nearly the same think it will be better to avoid have
> 2 configs specialy when there are the same
Please feel free to submit a patch if you do not like the current
design. But this has nothing to do with the current patch in
question, i. e. it is not a reason to reject it or ask for changes.
> btw I've found nothing about it in the README
Indeed, documentation is not exactly perfect. Please feel free to
submit a patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Heavier than air flying machines are impossible.
-- Lord Kelvin, President, Royal Society, c. 1895
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
