On 3 November 2015 at 05:19, Nikita Kiryanov <nik...@compulab.co.il> wrote: > Make spl_*_load_image() functions return a value instead of > hanging if a problem is encountered. This enables main spl code > to make the decision whether to hang or not, thus preparing > it to support alternative boot devices. > > Some boot devices (namely nand and spi) do not hang on error. > Instead, they return normally and SPL proceeds to boot the > contents of the load address. This is considered a bug and > is rectified by hanging on error for these devices as well. > > Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il> > Cc: Igor Grinberg <grinb...@compulab.co.il> > Cc: Tom Rini <tr...@konsulko.com> > Cc: Simon Glass <s...@chromium.org> > Cc: Ian Campbell <i...@hellion.org.uk> > Cc: Hans De Goede <hdego...@redhat.com> > Cc: Albert Aribaud <albert.u.b...@aribaud.net> > Cc: Jagan Teki <jt...@openedev.com> > --- > Changes in V3: > - Added documentation for spl_board_load_image(). > > Changes in V2: > - Minor collateral adjustments from changes in patch 2 (only one > return > statement at the end of spl_mmc_load_image). > > arch/arm/cpu/armv7/sunxi/board.c | 4 +++- > arch/arm/include/asm/spl.h | 10 ++++++++-- > common/spl/spl.c | 43 > +++++++++++++++++++++++++++------------- > common/spl/spl_mmc.c | 26 ++++++++++++++---------- > common/spl/spl_nand.c | 18 +++++++++++------ > common/spl/spl_net.c | 9 ++++++--- > common/spl/spl_nor.c | 6 ++++-- > common/spl/spl_onenand.c | 4 +++- > common/spl/spl_sata.c | 11 +++++++--- > common/spl/spl_usb.c | 17 ++++++++++------ > common/spl/spl_ymodem.c | 5 +++-- > drivers/mtd/spi/spi_spl_load.c | 17 +++++++++++----- > include/spl.h | 18 ++++++++--------- > 13 files changed, 123 insertions(+), 65 deletions(-) >
Reviewed-by: Simon Glass <s...@chromium.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot