Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

[Jagan Teki]

On 25 October 2015 at 19:34, Tom Rini <tr...@konsulko.com> wrote:
> On Sun, Oct 25, 2015 at 07:22:24PM +0530, Jagan Teki wrote:
>> On 25 October 2015 at 19:17, Tom Rini <tr...@konsulko.com> wrote:
>> > On Sun, Oct 25, 2015 at 09:36:59AM +0530, Jagan Teki wrote:
>> >
>> >> - Use __func__ on debug
>> >> - Removed unnecessary comment
>> >>
>> >> Signed-off-by: Jagan Teki <jt...@openedev.com>
>> >> ---
>> >>  drivers/spi/zynq_qspi.c | 8 +++-----
>> >>  1 file changed, 3 insertions(+), 5 deletions(-)
>> >>
>> >> diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c
>> >> index 8aa61d7..defc50e 100644
>> >> --- a/drivers/spi/zynq_qspi.c
>> >> +++ b/drivers/spi/zynq_qspi.c
>> >> @@ -430,7 +430,6 @@ static int zynq_qspi_start_transfer(struct 
>> >> zynq_qspi_priv *priv)
>> >>               zynq_qspi_fill_tx_fifo(priv, priv->fifo_depth);
>> >>
>> >>       writel(ZYNQ_QSPI_IXR_ALL_MASK, &regs->ier);
>> >> -     /* Start the transfer by enabling manual start bit */
>> >>
>> >>       /* wait for completion */
>> >>       do {
>> >> @@ -516,7 +515,7 @@ static int zynq_qspi_xfer(struct udevice *dev, 
>> >> unsigned int bitlen,
>> >>       priv->rx_buf = din;
>> >>       priv->len = bitlen / 8;
>> >>
>> >> -     debug("spi_xfer: bus:%i cs:%i bitlen:%i len:%i flags:%lx\n",
>> >> +     debug("zynq_spi_xfer: bus:%i cs:%i bitlen:%i len:%i flags:%lx\n",
>> >>             bus->seq, slave_plat->cs, bitlen, priv->len, flags);
>> >
>> > Switch to __func__ here.
>>
>> Apologies for the mistake here will update the commit message on the branch.
>
> Well, not just the commit message but the debug() too, you say
> "zynq_spi_xfer" in "zynq_qspi_xfer" so we really do want __func__ ;)
>

OK, _func__ not used here but for remaining speed and mode functions -
Will update accordingly.

-- 
Jagan | openedev.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot