Hi Tom, > On Mon, Oct 19, 2015 at 6:07 AM, Lukasz Majewski > <l.majew...@samsung.com> wrote: > >> On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski > >> <l.majew...@samsung.com> wrote: > >> >> From: Fabio Estevam <fabio.este...@freescale.com> > >> >> > >> >> SPI NOR flashes need to erase the entire sector size and we > >> >> cannot pass any arbitrary length for the erase operation. > >> >> > >> >> To illustrate the problem: > >> >> > >> >> Copying data from PC to DFU device > >> >> Download [=========================] 100% 478208 bytes > >> >> Download done. > >> >> state(7) = dfuMANIFEST, status(0) = No error condition is > >> >> present state(10) = dfuERROR, status(14) = Something went > >> >> wrong, but the device does not know what it was > >> >> Done! > >> >> > >> >> In this case, the binary has 478208 bytes and the M25P32 SPI NOR > >> >> has an erase sector of 64kB. > >> >> > >> >> 478208 = 7 entire sectors of 64kiB + 19456 bytes. > >> >> > >> >> Erasing the first seven 64 kB sectors works fine, but when > >> >> trying to erase the remainding 19456 causes problem and the > >> >> board hangs. > >> >> > >> >> Fix the issue by always erasing with the erase sector size. > >> >> > >> >> Signed-off-by: Fabio Estevam <fabio.este...@freescale.com> > >> > >> > Acked-by: Lukasz Majewski <l.majew...@samsung.com> > >> > > >> > Applied to u-boot-dfu tree. > >> > > >> > Thanks for your work. > >> > > >> > I'm looking forward for more patches :-) > >> > >> Any chance of getting this one applied for 2015.10? > > > > Probably not :-( since we have now -rc5. > > > > I plan to send pull request in the next merge window. > > > > My apologies, since I was busy with ELCE2015 preparation, so I've > > forgotten to send early PR to Marek. > > This has been acked in September and it is a very trivial change, why > not include it? >
Two patches to be applied as fixes for dfu subsystem. https://patchwork.ozlabs.org/patch/520827/ https://patchwork.ozlabs.org/patch/521575/ -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
