Hi Paul, On 16 October 2015 at 15:51, Paul Gortmaker <paul.gortma...@windriver.com> wrote: > On 2015-10-06 11:27 AM, Paul Gortmaker wrote: >> On 2015-10-05 08:53 PM, Paul Gortmaker wrote: >>> [Re: [U-Boot] [PATCH 5/5] sbc8641d: enable and test >>> CONFIG_SYS_GENERIC_BOARD] On 04/10/2015 (Sun 01:45) Masahiro Yamada wrote: >>> >> >> [...] >> >>> >>>> >>>> Any plan about this patch? >>>> >>>> I think this is the last non-generic board for PowerPC architecture. >>>> >>>> This board is still keeping us from removing arch/powerpc/lib/board.c >>> >>> Let me see if I can identify the exact line of change that breaks >>> booting tomorrow, and maybe then Simon or someone can suggest next steps >>> from there. >> >> So I broke down the suspect patch into three chunks, testing each >> chunk as I went and it booted each time. A git diff of my split >> by 3 vs a cherry pick of what I thought was the offending commit >> shows nothing. >> >> So at this point, it seems the bisect returned the wrong result, >> which is odd, since it seemed the same for sbc8548 and sbc8641. >> Maybe a makefile bug let an object file get re-used that should >> not have been? I'll do distclean in each bisect step in the >> future. >> >> I'll have another chance to work on this Thurs AM, and I'm curious >> to get to the bottom of this, so I'll follow up then with what I >> find out. > > OK. So I finally got to the bottom of this and now it makes more > sense. The monitor len was set to 256k and we were flirting with > breaking that threshold based on .config settings and where we > were in the tree ; my 2nd bisect led me to 2015.07-ish stuff and > there I saw this when comparing the passing build with the fail: > > u-boot$git describe 6eed3786c68c8a49d > v2015.07-rc1-412-g6eed3786c68c > ^^^ > > u-boot$ls -l ../41*/u-boot.bin > -rwxrwxr-x 1 paul paul 261476 Oct 16 16:47 ../411/u-boot.bin > -rwxrwxr-x 1 paul paul 266392 Oct 16 16:43 ../412/u-boot.bin > u-boot$bc > bc 1.06.95 > Copyright 1991-1994, 1997, 1998, 2000, 2004, 2006 Free Software > Foundation, Inc. > This is free software with ABSOLUTELY NO WARRANTY. > For details type `warranty'. > 256*1024 > 262144 > > The 412 commit added CONFIG_NET to the board and added 5k to the image > which broke the 256k limit. Not sure why the earlier bisect that led > to Simon's commit was breaking initially, but then not reproducible; > I'm guessing that I wasn't re-running the defconfig step for each bisect > step perhaps? > > I'll send a v2 of the series with 384k mon len shortly ; I have it > booting on today's master commit now.
Great that you got to the bottom of this! I wonder if we could add a check for CONFIG_SYS_MONITOR_LEN being too msmall? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
