On Friday, October 09, 2015 at 11:03:36 AM, Thomas Chou wrote: > Hi Marek,
Hi, > On 10/09/2015 05:14 AM, Marek Vasut wrote: > > Did I miss the DT part somewhere or is that not part of this patch ? > > As we are just barely starting from reset, there is no luxury of DT. > After this, DT will be used with the cache flush patch. That's right. > > Another question I have is -- why don't we set CONFIG_SYS_{I,D}CACHE_SIZE > > to maximum value? This should work for all nios2 cache configurations > > and it should also be correct, no ? Speed might be a bit of an issue > > here, but I doubt the impact would be that large. > > I am doing all the best to get rid of the CONFIG_SYS_{I,D}CACHE_SIZE... > So I avoid to use the same macro names. Here I use the maximum value in > this startup only. The speed penalty is only once here. After we get DT > initialized, we have the correct values of cache configuration. Ah, right. That's good. > It might be awful to use the maximum value all the time. See, we flush > cache for every eth packet! You should only flush the part where the packet is located ;-) I finally have the MAX10 kit, so I can check the ethernet at least :) > Thanks a lot for your review. Thanks for keeping up with my weird questions ;-) Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot