Hi Bin, On Thu, Sep 10, 2015 at 7:49 PM, Bin Meng <[email protected]> wrote: > Hi Joe, > > On Fri, Sep 11, 2015 at 6:32 AM, Joe Hershberger > <[email protected]> wrote: >> Hi Bin, >> >> On Thu, Sep 10, 2015 at 4:29 AM, Bin Meng <[email protected]> wrote: >>> When removing an Ethernet device, the MAC address saved in the dev's >>> platdata should be cleared. >> >> Why is this important to do? Test case? > > platdata->enetaddr was assigned to a value in last dev_probe(). If we > don't clear it, for dev_probe() the second time, dm eth will end up > treating it as a MAC address from ROM no matter where it came from > originally (maybe env, ROM, or even random) > > I don't think we need a test case to test this, but I can update > commit message to include the reason above.
OK. Sounds fine. Thanks, -Joe _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
