Hi Simon, On Tue, Sep 8, 2015 at 5:56 AM, Simon Glass <s...@chromium.org> wrote: > Hi Gary, > > On 7 September 2015 at 03:20, Gary Bisson > <gary.bis...@boundarydevices.com> wrote: >> Since last API changes for files >2GB, the read of symlink is broken as >> ext4fs_read_file now returns 0 instead of the length of the actual read. >> >> Signed-off-by: Gary Bisson <gary.bis...@boundarydevices.com> >> --- >> Hi all, >> >> Switching from an old v2014.07 to v2015.07 we've noticed that we couldn't >> read symlinks any more. This is due to the API changes made to >> ext4fs_read_file (commit 9f12cd0). >> >> This patch makes the read symlink check both for errors (status < 0) and >> actual read length. >> >> Regards, >> Gary > > Thanks for fixing this. Does the filesystem test (test/fs-test.sh) > show this error? How could we enhance the test to detect this?
I wasn't aware of this testing script, a quick look at it makes me think it doesn't check anything symlink-related. I guess it would require to add SYMLINK_FILE that points to either SMALL_FILE or BIG_FILE, read it and check the md5sum. Regards, Gary _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
