> -----Original Message----- > From: Ben Warren [mailto:biggerbadder...@gmail.com] > Sent: Tuesday, July 21, 2009 14:17 PM > To: Zang Roy-R61911 > Cc: Kumar Gala; U-Boot-Denx > Subject: Re: [U-Boot] [PATCH 1/2] Add ntel PCIE PRO/1000 > Network Driver support > > Hi Roy, > Roy Zang wrote: > > From: Roy Zang <tie-fei.z...@freescale.com> > > > > Based on Intel PRO/1000 Network Driver 7.3.20-k2 > > Add Intel E1000 PCIE card support. The following cards are added: > > INTEL_82571EB_COPPER > > INTEL_82571EB_FIBER, > > INTEL_82571EB_SERDES > > INTEL_82571EB_QUAD_COPPER > > INTEL_82571PT_QUAD_COPPER > > INTEL_82571EB_QUAD_FIBER > > INTEL_82571EB_QUAD_COPPER_LOWPROFILE > > INTEL_82571EB_SERDES_DUAL > > INTEL_82571EB_SERDES_QUAD > > INTEL_82572EI_COPPER > > INTEL_82572EI_FIBER > > INTEL_82572EI_SERDES > > INTEL_82572EI > > INTEL_82573E > > INTEL_82573E_IAMT > > INTEL_82573L > > INTEL_82546GB_QUAD_COPPER_KSP3 > > INTEL_80003ES2LAN_COPPER_DPT > > INTEL_80003ES2LAN_SERDES_DPT > > INTEL_80003ES2LAN_COPPER_SPT > > INTEL_80003ES2LAN_SERDES_SPT > > > > 82571EB_COPPER dual ports, > > 82572EI single port, > > 82572EI_COPPER single port PCIE cards > > and > > 82545EM_COPPER, > > 82541GI_LF > > pci cards are tested on P2020 board, MPC8536DS > > and MPC8544DS boards. > > > > Signed-off-by: Roy Zang <tie-fei.z...@freescale.com> > > > I have no objections to any of the content. A few themes, though: > > 1. Please ensure that the multi-line comments are formatted > correctly. > Lines 2+ should have a space in the first character. Do you find this issue in the patch?
> 2. If you insist on including dead code (i.e. #if 0), please > provide a > comment on why it's there Thanks for the understanding. The dead code in the previous file helped me track the code. That is why I left them. I will add the comment and remove the unnecessary one. > 3. I have a hard time believing that most of this is necessary. Sure > it's a complicated chip and you're pulling it from Intel's > driver, but > 3000+ lines is too much. Please try to remove stuff that's > not needed. I will double check it. Do not believe Intel's code. It take me two days to clean the code style. I will resend it after the code is ready. Thanks. Roy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
