________________________________________
From: Jean-Christophe PLAGNIOL-VILLARD [plagn...@jcrosoft.com]
Sent: Sunday, July 19, 2009 2:55 AM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish
Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 2/3] tools: mkimage (type=kwbimage) kirkwood boot
image support
On 07:15 Sun 19 Jul , Prafulla Wadaskar wrote:
> For more details refer docs/README.kwbimage
>
> Signed-off-by: Prafulla Wadaskar <prafu...@marvell.com>
> ---
> Makefile | 5 ++
> common/image.c | 1 +
> doc/README.kwbimage | 77 ++++++++++++++++++++++
> include/image.h | 1 +
> tools/Makefile | 1 +
> tools/kwbimage.c | 181
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> tools/kwbimage.h | 105 +++++++++++++++++++++++++++++
> tools/mkimage.c | 23 ++++++-
> 8 files changed, 393 insertions(+), 1 deletions(-)
> create mode 100644 doc/README.kwbimage
> create mode 100644 tools/kwbimage.c
> create mode 100644 tools/kwbimage.h
>
> diff --git a/Makefile b/Makefile
> index 55fc2a3..b9e45ed 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -339,6 +339,10 @@ $(obj)u-boot.img: $(obj)u-boot.bin
> sed -e 's/"[ ]*$$/ for $(BOARD) board"/') \
> -d $< $@
>
> +$(obj)u-boot.kwb: $(obj)u-boot.bin
> + ./tools/mkimage -n ./board/$(BOARDDIR)/kwbimage.cfg \
> + -T kwbimage -a $(TEXT_BASE) -e $(TEXT_BASE) -d $< $@
It will be better to make it a few more generic (and btw fix the out of tree
support) as this
MKIMAGE = $(OBJTREE)/tools/mkimage
[prafulla] this is generic change and should be done for other mkimage
references too.
for kwbimage patch I am skipping this, I will issue separate patch for this.
$(obj)u-boot.kwb: $(obj)u-boot.bin
$(MKIMAGE) -n $(KWD_CONFIG) -T kwbimage -a $(TEXT_BASE) \
-e $(TEXT_BASE) -d $< $@
[prafulla] done..
and in the board config.mk or soc anyother config.mk
KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
[prafulla] done in board config.mk,
thanks for this suggestion, this will add more flexibility to share kwbimage
config file for multiple boards
Regards..
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
