Hi,

On 06-08-15 18:10, Simon Glass wrote:
hi Hans,

On 1 August 2015 at 10:05, Simon Glass <s...@chromium.org> wrote:
Hi Hans,

On 25 July 2015 at 03:58, Hans de Goede <hdego...@redhat.com> wrote:
Currently the serial code assumes that there is always at least one serial
port (and panics / crashes due to null pointer dereferences when there is
none).

This makes it impossible to use u-boot on boards where there is no (debug)
serial port, because e.g. all uart pins are muxed to another function.

This commit adds a CONFIG_REQUIRE_SERIAL_CONSOLE Kconfig option, which
defaults to y (preserving existing behavior), which can be set to n on
such boards to make them work.

This commit only implements this for CONFIG_DM_SERIAL=y configs, as allowing
running without a serial port for CONFIG_DM_SERIAL=n configs is non trivial,
and is not necessary at this moment.

Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
  drivers/serial/Kconfig         | 11 +++++++++++
  drivers/serial/serial-uclass.c | 20 +++++++++++++++++---
  2 files changed, 28 insertions(+), 3 deletions(-)

Acked-by: Simon Glass <s...@chromium.org>

A few nits below.

Are you OK with me fixing the nits when I apply it or would you like to resent?

I was planning on doing a v2, but I have not found the time to do
so yet. So your offer to fix the nits sounds good. Please go ahead
and fix them.

Thanks & Regards,

Hans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to