Hi Simon, On Mon, Aug 3, 2015 at 6:31 AM, Simon Glass <s...@chromium.org> wrote: > Hi Bin, > > On 27 July 2015 at 01:45, Bin Meng <bmeng...@gmail.com> wrote: >> Hi Simon, >> >> With driver model pci conversion on x86 boards, we now missed the call >> to board_pci_pre_scan() and board_pci_post_scan() which are called in >> the non-dm path. For example, board_pci_post_scan() in >> arch/x86/lib/fsp/fsp_common.c is not called to do any work as >> requested by FSP after pci enumeration. >> >> I am not sure where we could insert these call back in the dm. Do you >> have any possible solution on this? > > I know that the post-scan is needed for FSP - and in fact for > Minnowmax I added in back in a recent patch[1]. What is the pre-scan > used for? > > Regards, > Simon > > [1] http://patchwork.ozlabs.org/patch/500864/
I see fsp_init_phase_pci() is called in arch_misc_init() which is really late in your patch. According to FSP spec, we should call this as soon as pci bus is enumerated. The original non-dm codes does this correctly. As for pre-scan, so far it does nothing. I believe we can drop it. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
